Skip to content

Fix footer links in index.html and project.html#233

Open
anishakujur367-alt wants to merge 2 commits into
komalharshita:mainfrom
anishakujur367-alt:fix-footer-github-links
Open

Fix footer links in index.html and project.html#233
anishakujur367-alt wants to merge 2 commits into
komalharshita:mainfrom
anishakujur367-alt:fix-footer-github-links

Conversation

@anishakujur367-alt
Copy link
Copy Markdown

@anishakujur367-alt anishakujur367-alt commented May 17, 2026

Summary [required]

This PR fixes footer and navigation links in DevPath that were previously pointing to the generic GitHub homepage instead of the correct repository resources.

It updates all affected links and replaces hardcoded GitHub URLs with a reusable repo_url variable in both templates for better maintainability.

Related Issue [required]

Closes #79

Type of Change [required]

  • Bug fix — resolves a broken behaviour
  • Feature — adds new functionality
  • Data — adds new projects to data/projects.json
  • Documentation — updates docs, README, or code comments only
  • Style — CSS or visual changes only, no logic change
  • Refactor — restructures code without changing behaviour
  • Test — adds or updates tests

What Was Changed [required]

File Change made
templates/index.html Fixed footer and navbar GitHub links, updated CONTRIBUTING, Issues, License URLs, and introduced repo_url variable
templates/project.html Updated GitHub links to use repo_url variable for consistency

How to Test This PR [required]

  1. Clone this branch: git checkout your-branch-name
  2. Install dependencies: pip install -r requirements.txt
  3. Run the app: python app.py
  4. Open http://127.0.0.1:5000 and...
  5. Run the tests: python tests/test_basic.py

Expected test output:

27 passed, 0 failed out of 27 tests

Test Results [required]

paste output here

Screenshots (if UI change)

Before After
screenshot screenshot

Self-Review Checklist [required]

  • I have read CONTRIBUTING.md and followed all guidelines
  • My branch name follows the convention: feat/, fix/, docs/, data/, style/, test/
  • I have run python tests/test_basic.py and all 27 tests pass
  • I have run flake8 . locally and there are no errors
  • I have not introduced any print() or console.log() debug statements
  • Every new function I wrote has a docstring
  • I have not modified files outside the scope of the linked issue
  • If I changed the UI, I tested it at 375px (mobile) and 1280px (desktop)
  • If I added a project to the dataset, it has all required JSON fields

Notes for Reviewer

@vercel
Copy link
Copy Markdown

vercel Bot commented May 17, 2026

@anishakujur367-alt is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting your first pull request to DevPath.

Before review:

  • Complete the PR template fully
  • Ensure all tests pass
  • Link your PR to an issue
  • Keep changes scoped to the issue

A maintainer will review your contribution soon.

@anishakujur367-alt
Copy link
Copy Markdown
Author

Hi @komalharshita,

I have resolved all merge conflicts and updated the PR.
Could you please review it when you get time?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace all placeholder https://github.com footer links with real repository URLs

1 participant